Messages in this thread | | | Date | Thu, 26 Jul 2012 14:43:02 +0400 | From | Pavel Emelyanov <> | Subject | Re: [patch 2/7] procfs: Convert /proc/pid/fdinfo/ handling routines to seq-file |
| |
On 07/25/2012 01:47 PM, Cyrill Gorcunov wrote: > This patch converts /proc/pid/fdinfo/ handling routines to seq-file which > is needed to extend seq operations and plug in auxiliary fdinfo provides > from subsystems like eventfd/eventpoll/fsnotify. > > Note the proc_fd_link no longer call for proc_fd_info, simply because > proc_fd_info is converted to seq_fdinfo_open (which is seq-file open() > prototype), moreover in further patches I need to provide two seq_fdinfo_open > variants -- one with CONFIG_CHECKPOINT_RESTORE and one without this > symbol. All in one -- this will look more messy then.
This is something I'm really not happy with :( After the set applied we will have one former proc_fd_info being splitted into 3 (three!) functions doing the same (with flavors).
For me it's better to fix this, otherwise conversion to seq-file looks OK.
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org> > CC: Al Viro <viro@ZenIV.linux.org.uk> > CC: Alexey Dobriyan <adobriyan@gmail.com> > CC: Andrew Morton <akpm@linux-foundation.org> > CC: Pavel Emelyanov <xemul@parallels.com> > CC: James Bottomley <jbottomley@parallels.com> > --- > fs/proc/fd.c | 133 +++++++++++++++++++++++++++++++++++++---------------------- > 1 file changed, 85 insertions(+), 48 deletions(-)
| |