lkml.org 
[lkml]   [2012]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 1/6] rtc: omap: kicker mechanism support
Date
Hi Sergei,

On Wed, Jul 25, 2012 at 16:45:29, Sergei Shtylyov wrote:

> > +/* OMAP_RTC_KICKER values */
> > +#define KICK0_VALUE (0x83e70b13)
> > +#define KICK1_VALUE (0x95a4f1e0)
>
> Parens not needed around simple literals.

Thanks for catching it

>
> > static void __iomem *rtc_base;
> >
> > #define rtc_read(addr) __raw_readb(rtc_base + (addr))
> > #define rtc_write(val, addr) __raw_writeb(val, rtc_base + (addr))
> >
> > +#define rtc_writel(val, addr) writel(val, rtc_base + (addr))
> > +
>
> Why not __raw_writel() like the above functions?

This driver would be used in AM335X, it being ARMv7, writel would be
safe (existing __raw_readb/__raw_writeb too needs to be replaced)

Regards
Afzal


\
 
 \ /
  Last update: 2012-07-25 16:42    [W:0.434 / U:1.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site