Messages in this thread Patch in this message | | | Date | Fri, 20 Jul 2012 15:34:43 -0700 | From | tip-bot for Alex Shi <> | Subject | [tip:x86/mm] x86/tlb: Fix build warning and crash when building for !SMP |
| |
Commit-ID: 7efa1c87963d23cc57ba40c07316d3e28cc75a3a Gitweb: http://git.kernel.org/tip/7efa1c87963d23cc57ba40c07316d3e28cc75a3a Author: Alex Shi <alex.shi@intel.com> AuthorDate: Fri, 20 Jul 2012 09:18:23 +0800 Committer: H. Peter Anvin <hpa@zytor.com> CommitDate: Fri, 20 Jul 2012 15:01:48 -0700
x86/tlb: Fix build warning and crash when building for !SMP
The incompatible parameter of flush_tlb_mm_range cause build warning. Fix it by correct parameter.
Ingo Molnar found that this could also cause a user space crash.
Reported-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Reported-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Alex Shi <alex.shi@intel.com> Link: http://lkml.kernel.org/r/1342747103-19765-1-git-send-email-alex.shi@intel.com Signed-off-by: H. Peter Anvin <hpa@zytor.com> --- arch/x86/include/asm/tlbflush.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h index b5a27bd..74a4433 100644 --- a/arch/x86/include/asm/tlbflush.h +++ b/arch/x86/include/asm/tlbflush.h @@ -105,10 +105,10 @@ static inline void flush_tlb_range(struct vm_area_struct *vma, __flush_tlb(); } -static inline void flush_tlb_mm_range(struct vm_area_struct *vma, +static inline void flush_tlb_mm_range(struct mm_struct *mm, unsigned long start, unsigned long end, unsigned long vmflag) { - if (vma->vm_mm == current->active_mm) + if (mm == current->active_mm) __flush_tlb(); }
| |