Messages in this thread | | | Subject | Re: [PATCH] sunrpc: clnt: Add missing braces | From | Joe Perches <> | Date | Fri, 20 Jul 2012 09:50:59 -0700 |
| |
On Wed, 2012-07-18 at 11:17 -0700, Joe Perches wrote: > Add a missing set of braces that commit 4e0038b6b24 > ("SUNRPC: Move clnt->cl_server into struct rpc_xprt") > forgot. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > net/sunrpc/clnt.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c > index f56f045..aaf70aa 100644 > --- a/net/sunrpc/clnt.c > +++ b/net/sunrpc/clnt.c > @@ -1844,12 +1844,13 @@ call_timeout(struct rpc_task *task) > return; > } > if (RPC_IS_SOFT(task)) { > - if (clnt->cl_chatty) > + if (clnt->cl_chatty) { > rcu_read_lock(); > printk(KERN_NOTICE "%s: server %s not responding, timed out\n", > clnt->cl_protname, > rcu_dereference(clnt->cl_xprt)->servername); > rcu_read_unlock(); > + } > if (task->tk_flags & RPC_TASK_TIMEOUT) > rpc_exit(task, -ETIMEDOUT); > else
Hi David.
I think it'd be good to get this into 3.6 as a bug fix.
This is marked in netdev patchwork as "not applicable".
Do you need the sunrpc maintainers to apply or ack it and then push it to you?
Trond? Bruce?
| |