Messages in this thread | | | Date | Fri, 20 Jul 2012 10:54:17 -0500 | From | Jonathan Nieder <> | Subject | Re: [PATCH 06/34] vmscan: add shrink_slab tracepoints |
| |
Mel Gorman wrote: > On Thu, Jul 19, 2012 at 05:07:21PM -0500, Jonathan Nieder wrote:
>> Some of the other patches of this type made sense, but I'd personally >> prefer if this one was dropped, yes. Though I am just a nobody that >> reads patches rather than one of the relevant people. ;-) > > It's a valid point but I'm going to leave it in for now and see what the > general opinion is.
Ok. To be more precise, this patch has two properties that other patches of the "make later patches easier to apply" class tend not to:
* it introduces a significant functional change (adding tracepoints) * it would have been very easy to skip
Have fun, and sorry for not explaining my reasoning before.
Ciao, Jonathan
| |