Messages in this thread | | | Date | Fri, 20 Jul 2012 15:03:59 +0200 | From | Borislav Petkov <> | Subject | Re: [RFC] firmware load: defer request_firmware during early boot and resume |
| |
On Fri, Jul 20, 2012 at 08:57:05PM +0800, Ming Lei wrote: > On Fri, Jul 20, 2012 at 8:52 PM, Borislav Petkov <bp@alien8.de> wrote: > > > This new SYSTEM_SUSPEND state is declared above and only assigned here > > to system_state without being tested anywhere. AFAICT, the only test > > you're doing is system_state != SYSTEM_RUNNING and that works without > > defining a new SYSTEM_SUSPEND state. > > > > So are you sure you really need it? > > If the approach is workable, I will rename SYSTEM_SUSPEND_DISK as > SYSTEM_SUSPEND since SYSTEM_SUSPEND_DISK is not used now.
This still doesn't change the fact that SYSTEM_SUSPEND or SYSTEM_SUSPEND_DISK is unused. IOW, both states are unused. So why introduce a new state instead of simply test != SYSTEM_RUNNING?
-- Regards/Gruss, Boris.
| |