lkml.org 
[lkml]   [2012]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mm: setup pageblock_order before it's used by sparse
From
On Sun, Jul 1, 2012 at 7:01 PM, Jiang Liu <jiang.liu@huawei.com> wrote:
> Hi Yinghai,
> The patch fails compilation as below:
> mm/page_alloc.c:151: error: initializer element is not constant
> mm/page_alloc.c:151: error: expected ‘,’ or ‘;’ before ‘__attribute__’
>
> On IA64, HUGETLB_PAGE_ORDER has dependency on variable hpage_shift.
> # define HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT)
> # define HPAGE_SHIFT hpage_shift
>
> And hpage_shift could be changed by early parameter "hugepagesz".
> So seems will still need to keep function set_pageblock_order().

ah, then use use _DEFAULT instead and later could update that in earlyparam.

So attached -v2 should work.

Thanks

Yinghai
[unhandled content-type:application/octet-stream]
\
 
 \ /
  Last update: 2012-07-02 23:21    [W:0.071 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site