Messages in this thread | | | Date | Mon, 2 Jul 2012 13:43:22 -0700 | Subject | Re: [PATCH] mm: setup pageblock_order before it's used by sparse | From | Yinghai Lu <> |
| |
On Sun, Jul 1, 2012 at 7:01 PM, Jiang Liu <jiang.liu@huawei.com> wrote: > Hi Yinghai, > The patch fails compilation as below: > mm/page_alloc.c:151: error: initializer element is not constant > mm/page_alloc.c:151: error: expected ‘,’ or ‘;’ before ‘__attribute__’ > > On IA64, HUGETLB_PAGE_ORDER has dependency on variable hpage_shift. > # define HUGETLB_PAGE_ORDER (HPAGE_SHIFT - PAGE_SHIFT) > # define HPAGE_SHIFT hpage_shift > > And hpage_shift could be changed by early parameter "hugepagesz". > So seems will still need to keep function set_pageblock_order().
ah, then use use _DEFAULT instead and later could update that in earlyparam.
So attached -v2 should work.
Thanks
Yinghai [unhandled content-type:application/octet-stream] | |