lkml.org 
[lkml]   [2012]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] leds-mc13783: set platform data to NULL at mc13783_led_remove
From
On Mon, Jul 2, 2012 at 7:23 PM, Bryan Wu <bryan.wu@canonical.com> wrote:
> On Mon, Jul 2, 2012 at 4:40 PM, Devendra Naga <devendra.aaru@gmail.com> wrote:
>> the platform_set_drvdata (pdev, NULL) to be set at the remove of the
>> driver, as we have set the platform data to led at probe.
>>
>> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
>
> Nice catch. I applied this patch in my for-next branch.
>
> But I also find the same issue in other LED drivers, are you
> interested in fixing them?
>
Yes, i will do those.
I will send out changes...
> Thanks,
> -Bryan
>

Thanks
>> ---
>> drivers/leds/leds-mc13783.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/leds/leds-mc13783.c b/drivers/leds/leds-mc13783.c
>> index 4cc6a2e..6515c11 100644
>> --- a/drivers/leds/leds-mc13783.c
>> +++ b/drivers/leds/leds-mc13783.c
>> @@ -372,6 +372,7 @@ static int __devexit mc13783_led_remove(struct platform_device *pdev)
>>
>> mc13xxx_unlock(dev);
>>
>> + platform_set_drvdata(pdev, NULL);
>> kfree(led);
>> return 0;
>> }
>> --
>> 1.7.9.5
>>
>
>
>
> --
> Bryan Wu <bryan.wu@canonical.com>
> Kernel Developer +86.186-168-78255 Mobile
> Canonical Ltd. www.canonical.com
> Ubuntu - Linux for human beings | www.ubuntu.com


\
 
 \ /
  Last update: 2012-07-02 18:41    [W:0.059 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site