Messages in this thread | | | Date | Fri, 20 Jul 2012 10:24:34 +0800 | From | Xiao Guangrong <> | Subject | Re: [PATCH 3/9] KVM: x86: introduce set_mmio_exit_info |
| |
On 07/20/2012 08:03 AM, Marcelo Tosatti wrote: > On Tue, Jul 17, 2012 at 09:52:13PM +0800, Xiao Guangrong wrote: >> Introduce set_mmio_exit_info to cleanup the common code >> >> Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com> >> --- >> arch/x86/kvm/x86.c | 33 +++++++++++++++++---------------- >> 1 files changed, 17 insertions(+), 16 deletions(-) > > This makes the code less readable IMO. The fragments are small enough > already. >
I think the function name set_mmio_exit_info has the better explanation - it generates a mmio-exit from the specified fragment.
Actually, the later patchset, readonly memeslot will set a new member in the mmio-exit-info:
run->mmio.write_readonly_mem = frag->write_readonly_mem;
If we wrap this operation up, i think the code should be neater. :)
| |