Messages in this thread | | | Date | Thu, 19 Jul 2012 16:53:21 -0700 | From | Greg KH <> | Subject | Re: [PATCH 00/90] staging: comedi: cleanup the pci_dev usage |
| |
On Wed, Jul 18, 2012 at 06:23:20PM -0700, H Hartley Sweeten wrote: > All the comedi pci drivers currently store a pointer to the pci_dev > in their private data. We can use the 'struct device *hw_dev' variable > in the comedi_device struct instead and introduce a wrapper for > to_pci_dev() to allow the drivers to easily get the pci_dev. > > This patchset does just that. It also removes the private data from > the drivers that no longer needed it. > > Some of the drivers required a bit of cleanup to their "find pci device" > code or the private data in order to make the conversion cleaner. > > There are still a couple drivers, specifically the ni and addi ones, > that need additional work before they can be converted cleanly.
I've applied all of these (with the updated 01/90 patch). Can you please send follow-on patches to resolve the issues that Ian pointed out?
thanks,
greg k-h
| |