lkml.org 
[lkml]   [2012]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 08/37] ARM: SAMSUNG: fix race in s3c_adc_start for ADC
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.4-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Todd Poynor <toddpoynor@google.com>

    commit 8265981bb439f3ecc5356fb877a6c2a6636ac88a upstream.

    Checking for adc->ts_pend already claimed should be done with the
    lock held.

    Signed-off-by: Todd Poynor <toddpoynor@google.com>
    Acked-by: Ben Dooks <ben-linux@fluff.org>
    Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/arm/plat-samsung/adc.c | 8 +++++---
    1 file changed, 5 insertions(+), 3 deletions(-)

    --- a/arch/arm/plat-samsung/adc.c
    +++ b/arch/arm/plat-samsung/adc.c
    @@ -157,11 +157,13 @@ int s3c_adc_start(struct s3c_adc_client
    return -EINVAL;
    }

    - if (client->is_ts && adc->ts_pend)
    - return -EAGAIN;
    -
    spin_lock_irqsave(&adc->lock, flags);

    + if (client->is_ts && adc->ts_pend) {
    + spin_unlock_irqrestore(&adc->lock, flags);
    + return -EAGAIN;
    + }
    +
    client->channel = channel;
    client->nr_samples = nr_samples;




    \
     
     \ /
      Last update: 2012-07-18 02:42    [W:3.084 / U:1.740 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site