Messages in this thread | | | Date | Tue, 17 Jul 2012 06:55:12 -0500 | From | "Gabriel M. Beddingfield" <> | Subject | Re: [alsa-devel] [PATCH 1/2] MFD: twl6040: Fix revision information |
| |
On 07/17/2012 01:39 AM, Rajeev kumar wrote: >> diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c >> index a36e9fc..2786de2 100644 >> --- a/sound/soc/codecs/twl6040.c >> +++ b/sound/soc/codecs/twl6040.c >> @@ -653,7 +653,7 @@ int twl6040_get_hs_step_size(struct snd_soc_codec >> *codec) >> { >> struct twl6040 *twl6040 = codec->control_data; >> >> - if (twl6040_get_revid(twl6040)< TWL6040_REV_ES1_2) >> + if (twl6040_get_revid(twl6040)< TWL6040_REV_ES1_3) > > > Instead of doing this change why not you take a #define for revision and > do > if (twl6040_get_revid(twl6040)< TWL6040_REV)
I disagree. The driver isn't just for one revision... it's for all of them. Peter's code is pretty clear as to what the situation is. Your suggestion hides it.
-gabriel
| |