lkml.org 
[lkml]   [2012]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V2 0/4] [SCSI] ufs: Adds glue drivers to ufshcd
Date
On Monday 16 July 2012, James Bottomley wrote:
> On Fri, 2012-07-13 at 15:45 +0000, Arnd Bergmann wrote:
> > On Friday 13 July 2012, Vinayak Holikatti wrote:
> > > This patch set adds following features
> > > - Seprates PCI specific code from ufshcd.c to make it as core
> > > - Adds PCI glue driver ufshcd-pci.c
> > > - Adds Platform glue driver ufshcd-pltfrm.c
> > > - Update correct transfer size in Command UPIU
> >
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> I need a maintainer ack for this to go upstream.
>
> Also, looking at this, I think this patch series isn't bisectable:
> Patch 1 removes PCI support and patch 2 adds it back in a different
> form. However, any PCI based UFS system would stop working if the
> bisect landed at patch 1. I think you can fix this just by combining
> patches 1 and 2.

I suggested to split the patch in two in a private review that we
did on the linaro mailing list. I gave my Ack because the split
was done, but I failed to notice that it was done differently
from what I suggested in

On Monday 02 July 2012, Arnd Bergmann wrote:
> I would recommend that you split this patch into two separate
> changesets, where you do all the changes to existing code in the
> first patch, and only move but don't change code in the second one
> that creates the new file.

I agree that breaking bisectibility by ripping out the PCI code
first is not good. The version 2 is not actually easier to review
at all than the first version, it just splits the changes by
file, which is pointless.

Arnd



\
 
 \ /
  Last update: 2012-07-16 22:41    [W:0.090 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site