Messages in this thread | | | Date | Sun, 15 Jul 2012 00:18:05 +0200 | Subject | Re: [PATCH 4/5] gpio: tps6586x: add gpio support through platform driver | From | Linus Walleij <> |
| |
On Fri, Jul 13, 2012 at 12:39 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
> Converting the gpio driver of tps6586x to a platform > driver in place of registering the gpio through core > driver. > The motivation of the change is: > - This is inline with the mfd drivers implementation. > - This will move the related gpio support to gpio driver > folder where all gpio related drivers are available. > This will be easy the maintenance and enhancement is > anything done for gpio. > - The gpio functionality can be selected through config > variable. > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Overall this is very, very good and you're doing the right thing.
> --- /dev/null > +++ b/drivers/gpio/gpio-tps6586x.c
> +#include <linux/i2c.h>
Why?
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |