lkml.org 
[lkml]   [2012]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 43/68] mtd: cafe_nand: fix an & vs | mistake
    Date
    From: Greg KH <gregkh@linuxfoundation.org>

    3.0-stable review patch. If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 48f8b641297df49021093763a3271119a84990a2 upstream.

    The intent here was clearly to set result to true if the 0x40000000 flag
    was set. But instead there was a | vs & typo and we always set result
    to true.

    Artem: check the spec at
    wiki.laptop.org/images/5/5c/88ALP01_Datasheet_July_2007.pdf
    and this fix looks correct.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
    Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mtd/nand/cafe_nand.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mtd/nand/cafe_nand.c
    +++ b/drivers/mtd/nand/cafe_nand.c
    @@ -102,7 +102,7 @@ static const char *part_probes[] = { "cm
    static int cafe_device_ready(struct mtd_info *mtd)
    {
    struct cafe_priv *cafe = mtd->priv;
    - int result = !!(cafe_readl(cafe, NAND_STATUS) | 0x40000000);
    + int result = !!(cafe_readl(cafe, NAND_STATUS) & 0x40000000);
    uint32_t irqs = cafe_readl(cafe, NAND_IRQ);

    cafe_writel(cafe, irqs, NAND_IRQ);



    \
     
     \ /
      Last update: 2012-07-13 02:41    [W:8.595 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site