Messages in this thread | | | Date | Wed, 11 Jul 2012 14:06:10 +0300 | Subject | Re: [PATCH] resource: make sure requested range intersects root range | From | "Purdila, Octavian" <> |
| |
On Wed, Jul 11, 2012 at 5:09 AM, Ram Pai <linuxram@us.ibm.com> wrote:
> > Wait.. I am not sure this will fix the problem entirely. The above check > will handle the case where the range requested is entirey out of the > root's range. But if the requested range overlapps that of the root > range, we will still call __reserve_region_with_split() and end up with > a recursion if there is a overflow. Wont we? >
Good catch. I will fix this as well as address Andrew's and Joe's comments in a new patch. The only question is how to handle the overlap case:
(a) abort the whole request or
(b) try to reserve the part that overlaps (and adjust the request to avoid the overflow)
I think (b) is more in line with the current implementation for reservations.
| |