lkml.org 
[lkml]   [2012]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm: don't invoke __alloc_pages_direct_compact when order 0
    On Sun, Jul 08, 2012 at 11:33:14AM +0900, JoonSoo Kim wrote:
    > 2012/7/7 David Rientjes <rientjes@google.com>:
    > > On Sat, 7 Jul 2012, Joonsoo Kim wrote:
    > >
    > >> __alloc_pages_direct_compact has many arguments so invoking it is very costly.
    > >> And in almost invoking case, order is 0, so return immediately.
    > >>
    > >
    > > If "zero cost" is "very costly", then this might make sense.
    > >
    > > __alloc_pages_direct_compact() is inlined by gcc.
    >
    > In my kernel image, __alloc_pages_direct_compact() is not inlined by gcc.

    Indeed it is due to their being two callsites. In most cases, the page
    allocator takes care that functions have only one callsite so they get
    inlined.

    You say that invoking the function is very costly. I agree that a function
    call with that many parameters is hefty but it is also in the slow path of
    the allocator. For order-0 allocations we are about to enter direct reclaim
    where I would expect the cost far exceeds the cost of a function call.

    If the cost is indeed high and you have seen this in profiles then I
    suggest you create a forced inline function alloc_pages_direct_compact
    that does this;

    if (order != 0)
    __alloc_pages_direct_compact(...)

    and then call alloc_pages_direct_compact instead of
    __alloc_pages_direct_compact. After that, recheck the profiles (although I
    expect the difference to be marginal) and the size of vmlinux (if it gets
    bigger, it's probably not worth it).

    That would be functionally similar to your patch but it will preserve git
    blame, churn less code and be harder to make mistakes with in the unlikely
    event a third call to alloc_pages_direct_compact is ever added.

    Thanks.

    --
    Mel Gorman
    SUSE Labs


    \
     
     \ /
      Last update: 2012-07-10 13:21    [W:3.091 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site