Messages in this thread | | | Subject | Re: [patch] irq: use config_enabled(SMP) checks to cleanup irq_set_affinity() for UP | From | Suresh Siddha <> | Date | Thu, 07 Jun 2012 13:56:23 -0700 |
| |
On Thu, 2012-06-07 at 13:36 -0700, Yinghai Lu wrote: > On Thu, Jun 7, 2012 at 1:31 PM, Suresh Siddha <suresh.b.siddha@intel.com> wrote: > >> > >> can you just use > >> if (nr_cpu_ids > 1) > >> checking instead > >> if config_enabled(CONFIG_SMP) > > > > Idea is to not have any extra runtime checks if CONFIG_SMP is enabled > > and which is when all the smp affinity routines are used/invoked. > > then could use > if (NR_CPUS > 1)
What is the problem with using config_enabled(CONFIG_SMP)? People looking for "CONFIG_SMP" can easily identify the dependency.
thanks, suresh
| |