Messages in this thread | | | Date | Thu, 07 Jun 2012 11:46:22 +0900 | From | Minchan Kim <> | Subject | Re: [PATCH 2/2] zram: clean up handle |
| |
On 06/06/2012 02:04 PM, Nitin Gupta wrote:
> On 06/05/2012 12:23 AM, Minchan Kim wrote: > >> zram's handle variable can store handle of zsmalloc in case of >> compressing efficiently. Otherwise, it stores point of page descriptor. >> This patch clean up the mess by union struct. >> >> changelog >> * from v1 >> - none(new add in v2) >> >> Cc: Nitin Gupta <ngupta@vflare.org> >> Acked-by: Seth Jennings <sjenning@linux.vnet.ibm.com> >> Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> >> Signed-off-by: Minchan Kim <minchan@kernel.org> >> --- >> drivers/staging/zram/zram_drv.c | 77 ++++++++++++++++++++------------------- >> drivers/staging/zram/zram_drv.h | 5 ++- >> 2 files changed, 44 insertions(+), 38 deletions(-) >> > > > I think page vs handle distinction was added since xvmalloc could not > handle full page allocation. Now that zsmalloc allows full page
I see. I didn't know that because I'm blind on xvmalloc.
> allocation, we can just use it for both cases. This would also allow > removing the ZRAM_UNCOMPRESSED flag. The only downside will be slightly > slower code path for full page allocation but this event is anyways > supposed to be rare, so should be fine.
Fair enough. It can remove many code of zram. Okay. Will look into that.
Thanks.
-- Kind regards, Minchan Kim
| |