Messages in this thread | | | Date | Wed, 6 Jun 2012 13:19:49 -0500 | From | Scott Wood <> | Subject | Re: [PATCH v5 2/5] powerpc/85xx: add HOTPLUG_CPU support |
| |
On 06/06/2012 04:59 AM, Zhao Chenhui wrote: > On Tue, Jun 05, 2012 at 11:15:52AM -0500, Scott Wood wrote: >> On 06/05/2012 06:18 AM, Zhao Chenhui wrote: >>> If user does not enable kexec or hotplug, these codes are redundant. >>> So use CONFIG_KEXEC and CONFIG_HOTPLUG_CPU to gard them. >> >> My point is that these lists tend to grow and be a maintenance pain. >> For small things it's often better to not worry about saving a few >> bytes. For larger things that need to be conditional, define a new >> symbol rather than growing ORed lists like this. >> >> -Scott > > I agree with you in principle. But there are only two config options > in this patch, and it is unlikely to grow.
That's what everybody says when these things start. :-)
-Scott
| |