Messages in this thread | | | Date | Wed, 06 Jun 2012 11:17:46 -0700 (PDT) | Subject | Re: [PATCH v9] tilegx network driver: initial support | From | David Miller <> |
| |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Wed, 06 Jun 2012 20:10:23 +0200
> I am pretty sure this performance problem should be solved in net/{core| > ipv4|ipv6} instead > > What TCP performance do you get with TSO/GSO and SG off ?
We have other drivers already doing this.
I tried a few years ago to make this generic, because NIU could benefit from it as well, but I couldn't figure out a clean enough way to abstract this.
Therefore it is absolutely reasonable to continue to let drivers do this locally until we actually have a reasonable solution.
The gains are definitely significant for chips that lack real TSO hardware, I absolutely do not require "proof" of this, it is clearly evident to anyone who considers the issue.
| |