Messages in this thread | | | Date | Tue, 5 Jun 2012 11:18:15 -0700 | From | Asai Thambi S P <> | Subject | Re: [PATCH 1/2] mtip32xx: Remove 'registers' and 'flags' from sysfs |
| |
On 6/5/2012 2:33 AM, Greg KH wrote:
> On Mon, Jun 04, 2012 at 12:43:03PM -0700, Asai Thambi S P wrote: >> >> This patch removes entries 'registers' and 'flags' from sysfs. Updated ABI file >> to reflect this change. >> >> Reported-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> Signed-off-by: Asai Thambi S P <asamymuthupa@micron.com> > > Much nicer, thanks for doing this: > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > But, one question on a different sysfs file: > >> What: /sys/block/rssd*/status >> Date: April 2012 >> KernelVersion: 3.4 >> Contact: Asai Thambi S P <asamymuthupa@micron.com> >> Description: This is a read-only file. Indicates the status of the device. > > What "status" is this showing? Why is this a sysfs file? Who > needs/wants it?
This shows the device status - online, write_protect or thermal_shutdown. This would be used by management application.
> > Also, if you really want to properly create sysfs files, use the default > attributes for the driver. As it is, you are creating them after > userspace is notified about the device showing up, which races with the > creation of your additional file(s). Use the properly driver core field > to have the core create, and remove them, automatically, which saves you > code, and fixes bugs you didn't realize you had :)
I have not thought about this. Thanks for the insight. I will look into it.
-- Regards, Asai Thambi
| |