lkml.org 
[lkml]   [2012]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] mtip32xx: Create debugfs entries for troubleshooting
On 06/04/2012 09:44 PM, Asai Thambi S P wrote:
> @@ -4062,10 +4210,20 @@ static int __init mtip_init(void)
> }
> mtip_major = error;
>
> + if (!dfs_parent) {
> + dfs_parent = debugfs_create_dir("rssd", NULL);
> + if (IS_ERR_OR_NULL(dfs_parent)) {
> + printk(KERN_WARNING "Error creating debugfs parent\n");
> + dfs_parent = NULL;
> + }
> + }
> +

Why would dfs_parent ever be non-NULL here?

Apart from that, looks fine.

--
Jens Axboe



\
 
 \ /
  Last update: 2012-06-05 10:01    [W:0.059 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site