lkml.org 
[lkml]   [2012]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 2/5] powerpc/85xx: add HOTPLUG_CPU support
    On Mon, Jun 04, 2012 at 11:32:47AM -0500, Scott Wood wrote:
    > On 06/04/2012 06:04 AM, Zhao Chenhui wrote:
    > > On Fri, Jun 01, 2012 at 04:27:27PM -0500, Scott Wood wrote:
    > >> On 05/11/2012 06:53 AM, Zhao Chenhui wrote:
    > >>> -#ifdef CONFIG_KEXEC
    > >>> +#if defined(CONFIG_KEXEC) || defined(CONFIG_HOTPLUG_CPU)
    > >>
    > >> Let's not grow lists like this. Is there any harm in building it
    > >> unconditionally?
    > >>
    > >> -Scott
    > >
    > > We need this ifdef. We only set give_timebase/take_timebase
    > > when CONFIG_KEXEC or CONFIG_HOTPLUG_CPU is defined.
    >
    > If we really need this to be a compile-time decision, make a new symbol
    > for it, but I really think this should be decided at runtime. Just
    > because we have kexec or hotplug support enabled doesn't mean that's
    > actually what we're doing at the moment.
    >
    > -Scott

    If user does not enable kexec or hotplug, these codes are redundant.
    So use CONFIG_KEXEC and CONFIG_HOTPLUG_CPU to gard them.

    -Chenhui



    \
     
     \ /
      Last update: 2012-06-05 14:01    [W:5.848 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site