lkml.org 
[lkml]   [2012]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: comedi: remove private header comedi_pci.h
On Tue, May 22, 2012 at 11:06:24AM +0100, Ian Abbott wrote:
> On 2012-05-22 01:12, H Hartley Sweeten wrote:
> >Remove the private header, comedi_pci.h, by moving the two
> >helper functions into divers.c and providing the prototypes
> >in comedidev.h.
> >
> >This allows the comedi_pci_enable/disable helper functions
> >to be shared instead of having an inline version in every
> >comedi pci driver.
>
> I'm wondering if these functions should be EXPORT_SYMBOL() or
> EXPORT_SYMBOL_GPL() since they were originally inline functions.
>
> Opinions?

Are there any known out-of-tree comedi drivers? I say leave this as-is
and see if anyone complains :)

thanks,

greg k-h


\
 
 \ /
  Last update: 2012-06-05 09:01    [W:0.049 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site