lkml.org 
[lkml]   [2012]   [Jun]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] staging/wlan-ng: Fix the checkpatch warnings
From
Hi Greg,

Thanks for the review.

On Tue, Jun 5, 2012 at 9:28 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Sun, May 20, 2012 at 07:01:42PM +0530, Devendra Naga wrote:
>> Signed-off-by: Devendra Naga <devendra.aaru@gmail.com>
>> ---
>>  drivers/staging/wlan-ng/cfg80211.c |   27 +++++++++++++++++++--------
>>  1 file changed, 19 insertions(+), 8 deletions(-)
>
>
> Ok, you sent me 5 patches, all with the same subject (except for 3 of
> them you used x/3, which was nice, but you duplicated 3/3 for some
> reason.)
>
No i actually copy pasted your name wrongly, so i resent it again with
correct name.
> I can't accept that, please be more specific in your subject: line.
>
> Also, in the body, say exactly what checkpatch warnings you fixed, and,
> if you fixed more than one type of warning, that might indicate that you
> should break the patch up into different parts.
>
Ok. so similar changes constitute a patch, and if the change differs a
new patch should be there.
> So, I've dropped all 5 patches you've sent me, please redo and resend.
>
Thanks, i will redo again.
> thanks,
>
> greg k-h

Thanks,
Devendra.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-06-05 13:01    [W:0.043 / U:0.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site