Messages in this thread | | | Subject | Re: [PATCH 1/2] iommu: dmar: replace printks with appropriate pr_*() | From | Joe Perches <> | Date | Mon, 04 Jun 2012 15:15:37 -0700 |
| |
On Mon, 2012-06-04 at 17:29 -0400, Donald Dutile wrote: > Replace printk(KERN_* with pr_*() functions.
Please add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt before any include and remove the embedded PREFIX from each printk
> diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
[]
> break; > } > pdev = pci_get_slot(bus, PCI_DEVFN(path->dev, path->fn)); > if (!pdev) { > - printk(KERN_WARNING PREFIX > - "Device scope device [%04x:%02x:%02x.%02x] not found\n", > + pr_warn(PREFIX "Device scope device" > + "[%04x:%02x:%02x.%02x] not found\n", > segment, bus->number, path->dev, path->fn);
Please don't split any format string. You removed a space between the scope device and an open bracket. It's OK for format strings to exceed 80 chars.
| |