Messages in this thread | | | From | "Luck, Tony" <> | Subject | RE: [patch 1/2] x86: mce Cleanup timer mess | Date | Mon, 4 Jun 2012 18:14:38 +0000 |
| |
> Here Thomas changed original mode from "*n = max(*n/2, HZ/100);" > to "iv = max(iv, (unsigned long) HZ/100);", which means *iv* will not > be decremented but only incremented in _else_ branch. If so, eventually > the *iv will be equal to *check_interval*. I don't think it makes sense.
It looks like Thomas just forgot the "/ 2" there while cleaning up. I didn't see it either, nor did Boris when he acked it. Thank goodness for your extra eyes looking at this.
Please send patch to fix it (so you get credit).
-Tony
| |