Messages in this thread | | | Date | Mon, 4 Jun 2012 19:37:22 +0300 | From | Boaz Harrosh <> | Subject | Re: [uml-devel] [PATCH 13/24] TTY: um/line, use tty from tty_port |
| |
On 06/04/2012 07:29 PM, Richard Weinberger wrote:
> Am 04.06.2012 18:27, schrieb Boaz Harrosh: >> On 06/04/2012 06:42 PM, Richard Weinberger wrote: >> >>> Am 04.06.2012 17:41, schrieb Jiri Slaby: >>>> Hmm, I remember. I suggest you to split the patch into several pieces. >>>> For example moving the code from ->open into ->install can be done >>>> separately. Otherwise it's hard to tell what's wrong with the patch as >>>> a whole. >>>> >>>> Also, it would be good to see the patch rebased on the top of my >>>> patch, because tty_port_set/get pieces would be gone from your patch too. >>> >>> Okay, I'll redo it! >>> I've a much cleaner version in my local queue. >>> >> >> >> Can you send it my way, I'm still running broken, 3.4 Based ? >> > > Can you please first give Jiri's patches a try? > > [PATCH 12/24] TTY: um/line, add tty_port > [PATCH 13/24] TTY: um/line, use tty from tty_port >
OK Will do
Boaz
> Thanks, > //richard >
| |