lkml.org 
[lkml]   [2012]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH RFC] c_can_pci: generic module for c_can on PCI
Date
> > +static u16 c_can_pci_read_reg_aligned_to_16bit(struct c_can_priv
> > *priv, + void *reg)
>
> I'm a bit worried this function name might be too short ;)

I know :) I was inspired by the same function in c_can_platform.c


About these function I suggest to move them into c_can.c because they
are the same for c_can_platform.c and c_can_pci.c Then add a new field
c_can_priv->offset which can be used to shift the register offset
coherently with the memory alignment. Finally, remove c_can_priv-
>read_reg and c_can_priv->write_reg and use internal c_can.c function to
read and write registers.

static u16 c_can_read_reg(struct c_can_priv *priv, enum reg index)
{
return readw(priv->base + (priv->regs[index] << priv->offset));
}
static void c_can_write_reg(struct c_can_priv *priv, enum reg index,
u16 val)
{
writew(val, priv->base + (priv->regs[index] << priv->offset));
}


If it's ok, I can made a patch for this in the next days.

> > + * do not call pci_disable_device on sta2x11 because it
> > + * break all other Bus masters on this EP
> > + */
> > + if(pdev->vendor == PCI_VENDOR_ID_STMICRO &&
> > + pdev->device == PCI_DEVICE_ID_STMICRO_CAN)
> > + goto out;
>
> Is that the disabling or the dropping it into D3. We have a PCI quirk
> flag for the latter. See "quirk_no_ata_d3". That will also avoid any
> accidents elsewhere. Right now the quirk has "ata" in the name but the
> ata is just historically because we had to quirk various disk
> controllers.

We are investigating if this is still necessary on the current version
of the board.

--
Federico Vaga


\
 
 \ /
  Last update: 2012-06-04 19:21    [W:0.211 / U:0.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site