Messages in this thread | | | Date | Sun, 3 Jun 2012 16:20:21 +0200 | From | Samuel Thibault <> | Subject | Re: [PATCH] staging: speakup: fixed checkpatch and sparse warnings in selection.c |
| |
Chris Yungmann, le Sat 02 Jun 2012 12:32:38 -0500, a écrit : > @@ -132,7 +132,7 @@ int speakup_paste_selection(struct tty_struct *tty) > while (sel_buffer && sel_buffer_lth > pasted) { > set_current_state(TASK_INTERRUPTIBLE); > if (test_bit(TTY_THROTTLED, &tty->flags)) { > - if (in_atomic()) > + if (in_interrupt()) > /* if we are in an interrupt handler, abort */ > break; > schedule();
I'd rather keep in_atomic(), which is clearly known to be broken (see TODO above).
Samuel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |