Messages in this thread | | | From | Ohad Ben-Cohen <> | Date | Sun, 3 Jun 2012 15:54:39 +0300 | Subject | Re: [RFC 2/6] remoteproc: Pass struct fw to load_segments and find_rsc_table. |
| |
On Tue, May 22, 2012 at 4:26 PM, <sjur.brandeland@stericsson.com> wrote: > From: Sjur Brændeland <sjur.brandeland@stericsson.com> > > Use struct firmware as arguments to functions rproc_find_rcs_table() > and rproc_load_segments().
I'll keep reading through the patches to get the big picture, but in general, it's best just to provide the incentive behind every change in the commit log.
> +rproc_find_rsc_table(struct rproc *rproc, const struct firmware *fw, > int *tablesz) > { ... > + /* > + * The ELF entry point is the rproc's boot addr (though this is not > + * a configurable property of all remote processors: some will always > + * boot at a specific hardcoded address). > + */ > + rproc->bootaddr = ehdr->e_entry; > + ... > @@ -1032,15 +1039,8 @@ static int rproc_fw_boot(struct rproc *rproc, const struct firmware *fw) > - /* > - * The ELF entry point is the rproc's boot addr (though this is not > - * a configurable property of all remote processors: some will always > - * boot at a specific hardcoded address). > - */ > - rproc->bootaddr = ehdr->e_entry;
Is this change related?
Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |