Messages in this thread Patch in this message | | | From | JohnG <> | Subject | Re: fanotify issues in 2.6.34-rc6-next-20100506 | Date | Mon, 4 Jun 2012 01:49:17 +0000 (UTC) |
| |
> On Fri, 2010-05-07 at 11:24 +0200, Anders Blomdell wrote: > ... switch statements are hard.
Two years passed, but this patch was never applied and fanotify is as broken as it has been. So, two questions: - does anyone going to finally apply that patch (add "break" before case (FSNOTIFY_EVENT_NONE) in should_merge) - what is the status of fanotify? Does anybody still use it? Does it work (aside from this bug?)
Just in case, I copied that old patch below:
diff --git a/fs/notify/fanotify/fanotify.c b/fs/notify/fanotify/fanotify.c index bbcfccd..34c9661 100644 a/fs/notify/fanotify/fanotify.c +++ b/fs/notify/fanotify/fanotify.c @@ -21,6 +21,7 @@ static bool should_merge(struct fsnotify_event *old, struct fsnotify_event *new) if ((old->path.mnt == new->path.mnt) && (old->path.dentry == new->path.dentry)) return true; + break; case (FSNOTIFY_EVENT_NONE): return true; default:
| |