lkml.org 
[lkml]   [2012]   [Jun]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH for -3.5] memblock: free allocated memblock_reserved_regions later
Hello, Yinghai.

Just one nitpick.

On Fri, Jun 29, 2012 at 11:27:57AM -0700, Yinghai Lu wrote:
> /**
> * memblock_double_array - double the size of the memblock regions array
> * @type: memblock type of the regions array being doubled
> @@ -204,6 +192,7 @@ static int __init_memblock memblock_doub
> phys_addr_t new_area_size)
> {
> struct memblock_region *new_array, *old_array;
> + phys_addr_t old_alloc_size, new_alloc_size;
> phys_addr_t old_size, new_size, addr;
> int use_slab = slab_is_available();
> int *in_slab;
> @@ -217,6 +206,12 @@ static int __init_memblock memblock_doub
> /* Calculate new doubled size */
> old_size = type->max * sizeof(struct memblock_region);
> new_size = old_size << 1;
> + /*
> + * We need to allocated new one align to PAGE_SIZE,
> + * so late could free them completely.

An extra space and probably "so we can free them completely later"
fits better.

Thank you!

--
tejun


\
 
 \ /
  Last update: 2012-06-29 21:21    [W:0.065 / U:1.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site