Messages in this thread | | | Date | Fri, 29 Jun 2012 18:26:01 +0200 | From | Samuel Ortiz <> | Subject | Re: [PATCH 2/2] mfd: max77693: fix irq leak and wrong kfree call |
| |
Hi Axel,
On Fri, Jun 08, 2012 at 08:35:37AM +0800, Axel Lin wrote: > We need to call max77693_irq_exit() in max77693_i2c_probe error patch and > max77693_i2c_remove. > > Current code already uses devm_kzalloc() to allocate memory for max77693. > Thus we should not call kfree(max77693), otherwise we got double free. > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > --- > drivers/mfd/max77693.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > index 4055bc2..4251757 100644 > --- a/drivers/mfd/max77693.c > +++ b/drivers/mfd/max77693.c > @@ -122,7 +122,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c, > max77693->regmap = devm_regmap_init_i2c(i2c, &max77693_regmap_config); > if (IS_ERR(max77693->regmap)) { > ret = PTR_ERR(max77693->regmap); > - dev_err(max77693->dev,"failed to allocate register map: %d\n", > + dev_err(max77693->dev, "failed to allocate register map: %d\n", > ret); > goto err_regmap; > } This is an unrelated change. I applied this patch except for this chunk.
Cheers, Samuel.
-- Intel Open Source Technology Centre http://oss.intel.com/
| |