Messages in this thread | | | Date | Thu, 28 Jun 2012 09:08:28 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH 4/8 v3] i2c: i801: check and return errors during byte-by-byte transfers |
| |
On Thu, 28 Jun 2012 11:46:28 +0800, Daniel Kurtz wrote: > On Thu, Jun 28, 2012 at 12:51 AM, Jean Delvare <khali@linux-fr.org> wrote: > > On Wed, 27 Jun 2012 21:54:11 +0800, Daniel Kurtz wrote: > >> If an error is detected in the polling loop, abort the transaction and > >> return an error code. > >> > >> * DEV_ERR is set if the device does not respond with an acknowledge, and > >> the SMBus controller times out (minimum 25ms). > >> * BUS_ERR is set if a bus arbitration collision is detected. In other > >> words, when the SMBus controller tries to generate a START condition, but > >> detects that the SMBDATA is being held low, usually by another SMBus/I2C > >> master. > >> * FAILED is only set if a the transaction is set by software (using the > >> SMBHSTCNT KILL bit). > > That was supposed to say: > > * FAILED is only set if a transaction is stopped by software (using > the SMBHSTCNT KILL bit).
Changed, thanks!
> > Not quite sure what you mean with "set by software". Other than this, > > patch looks good, applied, thanks. > > Applied where? > I'd like to send a rebased patchset onto whatever you have already staged.
http://khali.linux-fr.org/devel/linux-3/jdelvare-i2c/
-- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |