Messages in this thread Patch in this message | | | Date | Thu, 28 Jun 2012 09:44:25 +0300 | From | Dan Carpenter <> | Subject | [patch 1/3] vfio: signedness bug in vfio_config_do_rw() |
| |
The "count" variable is unsigned here so the test for errors doesn't work.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c index a4f7321..10bc6a8 100644 --- a/drivers/vfio/pci/vfio_pci_config.c +++ b/drivers/vfio/pci/vfio_pci_config.c @@ -1487,7 +1487,7 @@ static ssize_t vfio_config_do_rw(struct vfio_pci_device *vdev, char __user *buf, if (perm->readfn) { count = perm->readfn(vdev, *ppos, count, perm, offset, &val); - if (count < 0) + if ((ssize_t)count < 0) return count; }
| |