Messages in this thread | | | Date | Thu, 28 Jun 2012 14:29:31 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v3 3/3] perf script/python: Pass event/thread/dso name and symbol info to event handler in python |
| |
Em Thu, Jun 28, 2012 at 04:50:27PM +0800, Feng Tang escreveu: > On Wed, 27 Jun 2012 15:58:17 -0300 > Arnaldo Carvalho de Melo <acme@redhat.com> wrote: > > Now old scrips will break, as the tuple they expect: > > > > (attr, sample, raw_data) > > > > will not be there. > > Actually, there are no such scripts out. Current perf python script only > supports the trace point type, while perl scriptt has the support for > general events. It is my first patch "perf script: Add general python > handler to process non-tracepoint events" which bring this (attr, sample, > raw_data) in to be on the same page as perl. So this won't be a problem > when the 3 patches are merged together.
Cool, I forgot about that, thanks for correcting me :-)
But even then, perf and python diverged in this... anyway, not a big deal, I guess, the info available for perl scripts will be available in the dict as well, right?
> > The first two patches in this series don't apply anymore, please find > > them attached fixed, please check if they work as expected.
> Thanks a lot for fixing them, I'll generate perf tool patch against the > "perf/core" branch of your git tree on kernel.org from now on. > > Btw, I have 2 more python scripts based on these patches, will add them > to this serie for your review.
Ok, will take a look at them.
- Arnaldo
| |