lkml.org 
[lkml]   [2012]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] Was: deferring __fput()
On 06/28, Al Viro wrote:
>
> The list removal logics in mine looks really ugly ;-/

Basically the code is almost the same as mine.

But task_work_add() can be simplified a bit, no need to check
last != NULL twice.

last = task->task_works ?: twork;
task->last_twork = twork;
twork->next = last->next; /* XXX */
last->next = twork;

If ->task_works == NULL, then XXX is meaningless but safe.

Oleg.



\
 
 \ /
  Last update: 2012-06-28 19:01    [W:0.120 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site