Messages in this thread | | | Date | Thu, 28 Jun 2012 18:22:53 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 0/4] Was: deferring __fput() |
| |
On 06/28, Al Viro wrote: > > The list removal logics in mine looks really ugly ;-/
Basically the code is almost the same as mine.
But task_work_add() can be simplified a bit, no need to check last != NULL twice.
last = task->task_works ?: twork; task->last_twork = twork; twork->next = last->next; /* XXX */ last->next = twork;
If ->task_works == NULL, then XXX is meaningless but safe.
Oleg.
| |