Messages in this thread | | | Date | Thu, 28 Jun 2012 11:38:15 +0800 | From | Zhao Chenhui <> | Subject | Re: [PATCH v6 1/5] powerpc/85xx: implement hardware timebase sync |
| |
On Wed, Jun 27, 2012 at 09:48:52PM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2012-06-27 at 18:21 +0800, Zhao Chenhui wrote: > > > What's that CONFIG option for ? > > > > > > Cheers, > > > Ben. > > > > This option is to guard the timebase sync routines. It is selected > > when KEXEC or HOTPLUG_CPU is enabled on Freescale Book-E platforms. > > Any reason not to just make it unconditional ? That sort of config > option tend to just confuse things and make bug reports harder to sort > out.... Also you decrease your test coverage. > > Cheers, > Ben.
The bootloader have done a timebase sync. If we do not need KEXEC or HOTPLUG_CPU feature, it is unnecessary to do it again at boot time of kernel. I only compile the timebase sync routines when users enable KEXEC or HOTPLUG_CPU.
-Chenhui
| |