Messages in this thread | | | Subject | Re: [PATCH next] kvm: Use pr_<level> | From | Joe Perches <> | Date | Wed, 27 Jun 2012 18:34:41 -0700 |
| |
On Wed, 2012-06-27 at 21:44 -0300, Marcelo Tosatti wrote: > The advantage is the added prefix?
All messages are automatically prefixed. For instance:
> > - printk(KERN_WARNING "Fail to find correlated MSI-X entry!\n"); > > + pr_warn("Fail to find correlated MSI-X entry!\n");
Now has a prefix that describes the module from which the message originates.
> $ grep limit Documentation/CodingStyle > The limit on the length of lines is 80 columns and this is a strongly > preferred limit.
Read further:
However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them.
cheers, Joe
| |