lkml.org 
[lkml]   [2012]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH next] kvm: Use pr_<level>
From
Date
On Wed, 2012-06-27 at 21:44 -0300, Marcelo Tosatti wrote:
> The advantage is the added prefix?

All messages are automatically prefixed.
For instance:

> > - printk(KERN_WARNING "Fail to find correlated MSI-X entry!\n");
> > + pr_warn("Fail to find correlated MSI-X entry!\n");

Now has a prefix that describes the module from which
the message originates.

> $ grep limit Documentation/CodingStyle
> The limit on the length of lines is 80 columns and this is a strongly
> preferred limit.

Read further:

However, never break user-visible strings such as
printk messages, because that breaks the ability to grep for them.

cheers, Joe




\
 
 \ /
  Last update: 2012-06-28 04:21    [W:0.045 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site