Messages in this thread | | | Date | Wed, 27 Jun 2012 13:15:57 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] perf: fix wrong hw_breakpoint documentation |
| |
Em Wed, Jun 27, 2012 at 05:59:34PM +0900, Namhyung Kim escreveu: > Hi, Jovi > > On Wed, 27 Jun 2012 16:39:19 +0800, Jovi Zhang wrote: > > From f5f9c3a064482cf3d0fb7ed788c66630bddbfc79 Mon Sep 17 00:00:00 2001 > > From: Jovi Zhang <bookjovi@gmail.com> > > Date: Wed, 27 Jun 2012 16:09:21 +0800 > > Subject: [PATCH] perf: fix wrong hw_breakpoint documentation > > > > read-write access hw_breakpoint event is passed as 'mem:addr', > > 'mem:0x1000:rw' is parsed as invalid argument currently. > > > > It should be a bug in event parser. I guess the patch below will fix it:
Jiri,
Ack? If so, Namhyung, can you send a patch with his Ack?
- Arnaldo
> > diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l > index 488362e14133..aafca33a8a09 100644 > --- a/tools/perf/util/parse-events.l > +++ b/tools/perf/util/parse-events.l > @@ -76,7 +76,7 @@ num_hex 0x[a-fA-F0-9]+ > num_raw_hex [a-fA-F0-9]+ > name [a-zA-Z_*?][a-zA-Z0-9_*?]* > modifier_event [ukhpGH]{1,8} > -modifier_bp [rwx] > +modifier_bp [rwx]+ > > %% >
| |