lkml.org 
[lkml]   [2012]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] rtc: ds1307: Register offset moved to chip description
From
Date
> 
> On Wed, Jun 27, 2012 at 10:24:02AM +1200, Austin Boyle wrote:
> > rtc: ds1307: Register offset moved to chip description
> >
> > From: Austin Boyle <Austin.Boyle@aviatnet.com>
> >
> > Register offset is added to chip description instead of being hard-coded
> > into probe function.
> >
> > Based on v3.5-rc4
> >
> > Cc: Wolfram Sang <w.sang@pengutronix.de>
> > Cc: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> > Cc: Alessandro Zummo <a.zummo@towertech.it>
> > Signed-off-by: Austin Boyle <Austin.Boyle@aviatnet.com>
>
> I would ack this patch immediately if it added another type using this
> feature. But only changing already working code doesn't seem necessary
> to me.
>
> Regards,
>
> Wolfram
>

That was my gut feeling too.

Jocke

\
 
 \ /
  Last update: 2012-06-27 16:41    [W:0.035 / U:1.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site