Messages in this thread | | | Date | Tue, 26 Jun 2012 21:29:11 -0700 (PDT) | From | David Rientjes <> | Subject | Re: [PATCH 8/8] release memory resources if hotadd_new_pgdat() failed |
| |
On Tue, 26 Jun 2012, Wen Congyang wrote:
> We should goto error to release memory resource if hotadd_new_pgdat() failed. > > Signed-off-by: Wen Congyang <wency@cn.fujitsu.com> > --- > mm/memory_hotplug.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 2a14d35..3796690 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -617,7 +617,7 @@ int __ref add_memory(int nid, u64 start, u64 size) > pgdat = hotadd_new_pgdat(nid, start); > ret = -ENOMEM; > if (!pgdat) > - goto out; > + goto error; > new_pgdat = 1; > } >
This is a generic memory hotplug patch and doesn't rely on the rest of the series, so let's cc the maintainer, Andrew Morton <akpm@linux-foundation.org>.
Acked-by: David Rientjes <rientjes@google.com>
| |