Messages in this thread | | | Date | Wed, 27 Jun 2012 10:20:42 +0100 | From | Ian Abbott <> | Subject | Re: [PATCH 16/36] staging: comedi: cb_pcidas: simplify the boardinfo |
| |
On 2012-06-27 01:56, H Hartley Sweeten wrote: > The boardinfo values 'has_ai_trig_gated' and 'has_ai_trig_invert' > are both only set for the "1602" versions of the boards supported > by this driver. > > Simplify the boardinfo, and the code, by replacing these two > variables with one "is_1602" variable.
This doesn't save any code and would make it harder to add a board that would need 'has_ai_trig_gated' and 'has_ai_trig_invert' set to different values (although it's pretty unlikely that new such boards would be added to this driver).
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
| |