| Date | Mon, 25 Jun 2012 16:23:52 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 09/11] memcg: propagate kmem limiting information to children |
| |
On Mon, 25 Jun 2012 18:15:26 +0400 Glauber Costa <glommer@parallels.com> wrote:
> --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -287,7 +287,11 @@ struct mem_cgroup { > * Should the accounting and control be hierarchical, per subtree? > */ > bool use_hierarchy; > - bool kmem_accounted; > + /* > + * bit0: accounted by this cgroup > + * bit1: accounted by a parent. > + */ > + volatile unsigned long kmem_accounted;
I suggest
unsigned long kmem_accounted; /* See KMEM_ACCOUNTED_*, below */
> bool oom_lock; > atomic_t under_oom; > @@ -340,6 +344,9 @@ struct mem_cgroup { > #endif > }; > > +#define KMEM_ACCOUNTED_THIS 0 > +#define KMEM_ACCOUNTED_PARENT 1
And then document the fields here.
|