Messages in this thread | | | Date | Thu, 21 Jun 2012 10:54:35 +0530 | From | Prashanth Nageshappa <> | Subject | Re: [PATCH v3] sched: balance_cpu to consider other cpus in its group as target of (pinned) task |
| |
On 06/21/2012 09:53 AM, Srivatsa Vaddagiri wrote:
> * Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com> [2012-06-21 09:10:59]: > >> Hmm ..I can see loop_break being incremented here: >> >> /* take a breather every nr_migrate tasks */ >> if (env->loop > env->loop_break) { >> env->loop_break += sched_nr_migrate_break; > > One possibility is to reset env->loop here, rather than loop_break, in > which case loop_break can remain constant across "redos" and > "more_balances"
We cannot do this as env->loop is compared with env->loop_max. So, I believe resetting env->loop_break along with env->loop before "redos" and "more_balances" is the right thing to do.
- Prashanth
| |