lkml.org 
[lkml]   [2012]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] checkpatch: Check usleep_range arguments
    From
    Date
    usleep_range shouldn't use the same args for min and max.

    Report it when it happens and when both args are decimal
    and min > max.

    Signed-off-by: Joe Perches <joe@perches.com>
    ---
    scripts/checkpatch.pl | 16 ++++++++++++++++
    1 files changed, 16 insertions(+), 0 deletions(-)

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index 630319a..d0c1a63 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -3309,6 +3309,22 @@ sub process {
    }
    }

    +# check usleep_range arguments
    + if ($^V && $^V ge 5.10.0 &&
    + defined $stat &&
    + $stat =~ /^\+(?:.*?)\busleep_range\s*\(\s*($FuncArg)\s*,\s*($FuncArg)\s*\)/) {
    + my $min = $1;
    + my $max = $7;
    + if ($min eq $max) {
    + WARN("USLEEP_RANGE",
    + "usleep_range should not use min == max args; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
    + } elsif ($min =~ /^\d+$/ && $max =~ /^\d+$/ &&
    + $min > $max) {
    + WARN("USLEEP_RANGE",
    + "usleep_range args reversed, use min then max; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
    + }
    + }
    +
    # check for new externs in .c files.
    if ($realfile =~ /\.c$/ && defined $stat &&
    $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)



    \
     
     \ /
      Last update: 2012-06-21 18:01    [W:2.648 / U:0.344 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site