Messages in this thread | | | Date | Thu, 21 Jun 2012 10:20:27 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 2/3] regulator: replace devm_gpio_request_one() for loaded module |
| |
On Thu, Jun 21, 2012 at 08:03:48AM +0000, Kim, Milo wrote: > At this moment, devm_gpio_request_one() has not been exported yet. > But lp872x driver can be used as a module, so related functions should be changed. > > devm_gpio_request_one() -> gpio_request_one() and gpio_free()
No, this is a step back in terms of the quality of the driver especially given that nobody is likely to actually use the driver when built as a module. We should just wait until the function is exported and then reenable modular builds. [unhandled content-type:application/pgp-signature] | |