Messages in this thread | | | Date | Wed, 20 Jun 2012 09:52:06 +0200 | Subject | Re: Q: return of pinctrl_register and handing at drivers that use this function | From | Linus Walleij <> |
| |
On Mon, Jun 18, 2012 at 4:42 PM, devendra.aaru <devendra.aaru@gmail.com> wrote: > On Mon, Jun 18, 2012 at 8:08 PM, Linus Walleij <linus.walleij@linaro.org> wrote: >> On Mon, Jun 18, 2012 at 2:04 PM, devendra.aaru <devendra.aaru@gmail.com> wrote: >> >>> So checking the return value of pinctrl_register with IS_ERR is not required. >> >> Nope. > > You mean to say that the check "IS_ERR(ret_ptr)" is not required? or > the other way like its also needed.
I mean it shall be tested like this:
if (!pinmctrl_register(&foo)) { /* error case */ }
No IS_ERR() business.
Linus
| |